akrieger
akrieger
> cc1plus: note: ‘-gsplit-dwarf’ is not supported with LTO, disabling Well there's your problem.
https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/9248288152/job/25561768627?pr=74067#step:14:533 Seems like it's still OOMing on some builds, in the dwp step.
Not sure if exactly whats causing the corruption but asan got this trace when I tried repro'ing. ``` ================================================================= ==7857==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300031a3b8 at pc 0x00000569c777 bp 0x7ffcba33d290...
nb. just `closest_points_first` by itself is like 30% of the cpu taken when kicking off a fresh sky islands run. I can cut that in half with some more templates...
" // City check is the fastest => it goes first." lol
As an aside, I had some ideas for speeding up nearest_points_first, which I'll go ahead and crack out while y'all hash out the algorithmic fixes.
Yeah nevermind there's no helping it. Replacing that hot loop with the non allocating version find_point_closest_first makes us spend maybe 20% less time in distance_to_city. So instead of being 60some%...
I don't really like the idea of sprinkling random +1s around? Wouldn't it be better to take away the random +1 thats happening? Where is that?
Yeah pretty sure if I were to implement that I'd have used `e.set_intensity( std::max( 1, e.get_duration() / e.get_int_dur_factor() ) );`
@sonphantrung can you try if the ~~ceil~~ max call I wrote fixes this from the other direction, by not unnecessarily buffing healing (or other low intensity effects)?