Koichi Murase
Koichi Murase
> but I still seem to have some issues with remote file: > > ``` > scp localhost:/home/yedaya/dev/bash-completion/test/fixtures/scp/local_path/backslash-a\\\ > ``` > > This happens also with main, so not a...
> ```diff > --- a/completions/ssh > +++ b/completions/ssh > @@ -546,3 +546,3 @@ _comp_xfunc_scp_compgen_remote_files() > # unescape (3 backslashes to 1 for chars we escaped) > - REPLY=$(command sed -e...
> **test/t/test_rsync.py:83** > > * The test for local path completion with spaces only checks that a value is returned without asserting a specific expected output. Consider adding an explicit...
> **test/t/test_rsync.py:85** > > * [nitpick] Add a comment to document the variations in expected output based on different rsync versions, so the reasoning behind the dual expectation is clear....
@yedayak I added many changes and squashed them into the corresponding commits. The changes after your previous review can be checked on [`b456d8d..1fd977d`](https://github.com/scop/bash-completion/compare/b456d8d8dd2d8b3338a929b7a4244eb0a389100c..1fd977d8444e122500a7fa6583204bb28cedd220).
Thank you. Yes..., I have to agree with you that this PR happened to become too large. I usually tend to combine multiple changes in a reasonable size of a...
I submitted PR #1371. > I believe for this to work the PR's need to be branches in this repo and not a fork, so this is an option directly...
@scop @yedayak This is the final change of this PR. I also adjusted the PR title to reflect the last change.
Thank you very much!