Koichi Murase

Results 585 comments of Koichi Murase

Bash language discussion These are also the points or just questions that I feel are caused by the lack of your Bash knowledge or the lack of programming experience: >...

And these points are something that I think we can discuss: > * `BASH_COMPLETION_FINALIZE_CMD_HOOKS` and `BASH_COMPLETION_FINALIZE_HOOKS` are always set, even if the feature isn't used at all... would be nice...

For the eval-related matter, to avoid confusion like this, we can use name references if we could update the requirements on the Bash version to 4.3+, yet that doesn't yet...

> > I take these comments as invalid ones. > > I hadn't said that there **were** injection holes,… I’ve asked whether there could be! ;-) OK, then that's fine!...

> Okay, but then I'd suggest to drop the `the` before `filter…` otherwise it sounds a bit strange. > What I'd perhaps do is to define exit statuses like the...

> That reads a bit unusual... exit statuses should be all other ones, so either `Any other exit status` or `The other exit statuses`. Thanks, I'll later modify it. (**edit**:...

> Is it OK if I close this, and reopen if upstream prefer it here? Sure!

Thank you for your quick responses and the kind reply! > I had saw the `words` variable. I will try to change the algorithm with using `words` variable soon. Got...

> I had saw the `words` variable. I will try to change the algorithm with using `words` variable soon. For reference, I think you can refer to the existing implementations...

FYI, Ville's reply to the customizability: https://github.com/scop/bash-completion/discussions/539#discussioncomment-830724. I'm not sure if we should unlimitedly add new configuration variables for these kinds of requests one by one. What if another user...