Aidan Reilly
Aidan Reilly
https://github.com/redhat-documentation/vale-at-red-hat/pull/764
Closed attribute block should not fire for JSON in a code block: https://github.com/openshift/openshift-docs/pull/74739/files/c270a8084990674061e268223deaba4cb21a2615#r1576081106
> Closed attribute block should not fire for JSON in a code block: > > https://github.com/openshift/openshift-docs/pull/74739/files/c270a8084990674061e268223deaba4cb21a2615#r1576081106 https://github.com/redhat-documentation/vale-at-red-hat/pull/777
Thanks for the PR. Any particular reason why you are targeting this repo with this update? You've not contributed here before.
Not required
I didn't make the SSG entry, merely quibbled its existence :) We could make a rule for this for sure.
No - actually the guidance from DXP is that it is fine and correct to apply `Red{nbsp}Hat` in source. So this is valid - we probably do need a suggestion...
See https://issues.redhat.com/browse/CCSOPS-1804
We support single and double quotes in the rules FYI: https://github.com/redhat-documentation/vale-at-red-hat/pull/613 I don't think we need to change this tbh
@dfitzmau can you update and get this one merged?