Aidan Reilly

Results 160 comments of Aidan Reilly

Does it make sense to manage these a single rules file, `RedHatProducts.yml` or similiar?

@themr0c OK yes I see what you are saying. Cool! Will try and get something together this week.

I think we could make this work. Need to look into this. I have a number of changes I need to do to the ssg vale rules generator before this.

I think this needs its own rule. What about: ```yml --- extends: existence message: Do not include a link to '%s' in documentation source unless it is explicitly approved. link:...

So your rules are looking for a slug after the URL, there will fire the rule: ``` https://github.com/project https://gitlab.com/project ``` these will not: ``` https://github.com https://gitlab.com ```

Are we sure that this directive (No Git links) applies to all projects under the Red Hat umbrella?

No you need to create a page + update the nav.adoc. See https://github.com/redhat-documentation/vale-at-red-hat/pull/634 for reference

If you search for `https://github.com/` in openshift-docs there are a lot of hits. I wonder if we set scope: sentence will that "tune" for less false positives? openshift-docs are allowed...

Maybe ``` --- extends: existence scope: raw level: error message: "Unescaped trailing backslash detected in codeblock." action: name: remove raw: - '(?

Yes I will collate a list for discussion here.