vale-at-red-hat
vale-at-red-hat copied to clipboard
ci(lint): add shell linter - Differential ShellCheck
Description
Addition of a new job in CI workflow that scans all shell scripts in the repo using ShellCheck and reports only newly added defects.
Differential ShellCheck is a GitHub action that performs differential ShellCheck scans on shell scripts changed via PR and reports results directly in PR.
It produces reports in SARIF format. GitHub understands this format and is able to display it nicely as a PR comment, and on the Files Changed tab, please see below.
Documentation is available at @redhat-plumbers-in-action/differential-shellcheck.
Screenshots
⚡️ Deploying PR Preview...
Thanks for the PR. Any particular reason why you are targeting this repo with this update? You've not contributed here before.
I just came across your org and this repo, and I noticed that you have some shell scripts and don't run ShellCheck in your CI.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
Seems a duplicate with https://github.com/redhat-documentation/vale-at-red-hat/blob/main/.github/workflows/validate-scripts.yml
Not required