Aidan Reilly

Results 160 comments of Aidan Reilly

Closing and waiting 15 min before reopening to kick Prow

This PR has been repointed to `gitops-docs-main` branch. `gitops-docs` is no longer in use and will be deleted presently. The gitops-docs-main branch uses the OpenShift Prow CI instead of Travis...

^^ updated [comment #1](https://github.com/openshift/openshift-docs/pull/72104#issue-2153633623) URL with updated build.

Felt this was important enough to complete so did it here: https://github.com/redhat-documentation/vale-at-red-hat/pull/780 Thanks for raising the PR. Feel free to update if you see a better solution

This rule does not account for specific ifeval situations. ``` ifeval::["{context}" == "build-strategies-docker"] :dockerstrategy: endif::[] ifeval::["{context}" == "build-strategies-docker"] :!dockerstrategy: endif::[] ``` Update the rule to respect ifeval boundaries. For example,...

> This rule does not account for specific ifeval situations. > > ``` > ifeval::["{context}" == "build-strategies-docker"] > :dockerstrategy: > endif::[] > > > > ifeval::["{context}" == "build-strategies-docker"] > :!dockerstrategy:...

> /cc What does this mean?

@jeana-redhat Given upcoming tooling changes, I don't think I will be able to spend more time getting this into a better state for AsciiDoc, this will have to do.

Merging this since it's reasonably useful and we're moving off AsciiDoc so why not? :shrug:

> Some good phrasal verb terms here pulled from the ISG: #809 Also maybe, "picks? up," "gives? up," or "sets? up"