Ignas Anikevicius

Results 504 comments of Ignas Anikevicius

Also we talked about the fact that the current algorithm is using `startswith`, which seems to be inefficient to do for each file. Ideas: 1. You can do this for...

@dougthor42, could you please comment on how you imagine the API work for the downloader configuration?

Why is rules_pycross using python3.8? It would be great if you could a little bit explain the breakage to me here.

Please also add a changelog note stating the minimum supported bazel versions coming with this change.

Just to add my notes from #3117, I think we should also wait until the packaging rules have caught up and support symlinks in `tar` files, i.e.: - Wait for...

No need to be sorry, thanks for reporting this - it helps others who search for a similar issue. What is the expected behaviour here?

In my view the `DEVELOPER_DIR` and `XCODE_VERSION` awarness on `osx` would be preferred, because otherwise if the Python version is changed underthehood, the cache within bazel cannot be invalidated. Am...

Thanks for getting back here and checking. Any extra information from your last debugging might be useful!

One way of thinking: The python_version within `pip.parse` is needed to select the right wheels if we are using the downloader. I would say that `pip.parse` in the jax and...

Extra thoughts - we could default to default python version if not specified in pip.parse and given that we already have an env var for controlling the python version, we...