Ignas Anikevicius

Results 504 comments of Ignas Anikevicius

Accepting `*` only as the first or last character in the glob sounds sensible - that way we can have checks of `startswith` and `endswith` because Starlark does not support...

Thanks for the suggestion. I am not sure that adding an extra dependency to the ruleset for this is worth it. Just supporting prefixes and suffixes is enough for the...

For now I am happy with any implementation as long as it does not bring extra deps to the ruleset. So supporting other globs is fine as well.

So if I understand correctly this breaks when trying to use the `MODULE.bazel.lock` file, right? I think the only solution, that I haven't gotten to doing yet is to implement...

The flag purpose is to support #260, but there were many things why it was not deemed as done and not enabled by default. The TLDR of what it (the...

I think I gave it enough thought and the best way I could think of to solve this is to move [this `select_requirement` call](https://github.com/bazelbuild/rules_python/blob/787f3cb081c34a304cb5b3f61db96ce40a14a5d6/python/private/pypi/extension.bzl#L316) from the `module_extension` evaluation into a...

I am wondering if bazelbuild/bazel#22865 is related. Could you please try if nondblzmod is the same overhead? Could you also check if precompiling py files to pyc helps (that is...

What is the performance if you launch the the script directly? I.e. `bazel build` + executing it instead of `bazel run`?

Commenting on feasibility of the suggested fixes: 1. Working well without runfiles support might bring too much Windows specific code that might become hard to test. I think a requirement...