rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

fix: Bump minimum protobuf version to 31.0 to fix dropped 3.8 support

Open Ahajha opened this issue 2 weeks ago • 3 comments

See https://github.com/jvolkman/rules_pycross/issues/209

The old protobuf version still needs Python 3.8, so attempting to load it fails. I see there is already a PR here (https://github.com/bazel-contrib/rules_python/pull/3367) but this is a much smaller change for an isolated issue.

Ahajha avatar Dec 07 '25 20:12 Ahajha

Summary of Changes

Hello @Ahajha, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue by upgrading the protobuf dependency to a newer version. The previous protobuf release no longer supported Python 3.8, leading to runtime errors. By bumping the version to 31.0-rc1, this change ensures continued compatibility with Python 3.8 environments, providing a targeted fix for the reported problem.

Highlights

  • Protobuf Version Update: The protobuf dependency has been updated from version 29.0-rc2 to 31.0-rc1 in the MODULE.bazel file.
  • Python 3.8 Compatibility Fix: This change specifically addresses an issue where the older protobuf version dropped support for Python 3.8, causing failures when attempting to load it.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 07 '25 20:12 gemini-code-assist[bot]

Why is rules_pycross using python3.8? It would be great if you could a little bit explain the breakage to me here.

aignas avatar Dec 11 '25 02:12 aignas

Rules_pycross isn't, it's just that it manifested there somehow. The issue is that the older version of protobuf is using 3.8, which was dropped in later versions.

Ahajha avatar Dec 11 '25 02:12 Ahajha