rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

build: add flag_alias definition for Starlarkification of python flags

Open aranguyen opened this issue 2 weeks ago • 2 comments

With this change, when user build with a native python flag, flag_alias will point to the starlark version of the flag. Please see design doc here for more details.

aranguyen avatar Dec 10 '25 15:12 aranguyen

Summary of Changes

Hello @aranguyen, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates flag_alias definitions into the MODULE.bazel file, a critical step in migrating Python build flags to a Starlark-based configuration system. By mapping existing native flags to their new Starlark implementations, the change ensures a smooth transition and consistent behavior for users while advancing the overall Starlarkification initiative.

Highlights

  • Starlarkification of Python Flags: This pull request adds flag_alias definitions to MODULE.bazel to facilitate the Starlarkification of Python-related build flags.
  • Flag Aliases Added: Specific aliases have been introduced for build_python_zip, incompatible_default_to_explicit_init_py, python_path, and experimental_python_import_all_repositories.
  • Mapping to Starlark Versions: These aliases ensure that when native Python flags are used, they correctly point to their Starlark-defined counterparts located under //python/config_settings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 10 '25 15:12 gemini-code-assist[bot]

Is flag_alias bazel 9+? All the CI jobs are failing because it's not available.

At the least, we need to support 8.x.

We can drop 7.x pretty soon -- I'm thinking the Jan release?

rickeylev avatar Dec 10 '25 16:12 rickeylev

This should work as a no-op in the latest bazel 8.x and 7.x releases.

i.e. they continue to read native flags as usual, so they parse these new entries but just skip over them.

gregestren avatar Dec 12 '25 23:12 gregestren

See https://github.com/bazelbuild/bazel/issues/27337 and https://github.com/bazelbuild/bazel/issues/27334.

gregestren avatar Dec 12 '25 23:12 gregestren

flag_alias() should work with latest 7.x and 8.x releases

Oh ok, that explains. Thanks. I updated the PR and it's using 8.5, but it still fails, error:

ERROR: /workdir/MODULE.bazel:460:11: Traceback (most recent call last):
	File "/workdir/MODULE.bazel", line 460, column 11, in <toplevel>
		flag_alias("build_python_zip", "//python/config_settings:build_python_zip")
Error in flag_alias: flag_alias() got unexpected positional argument

rickeylev avatar Dec 14 '25 23:12 rickeylev

@aranguyen I think you want to give the parameters names to fix that.

gregestren avatar Dec 15 '25 14:12 gregestren

Please also add a changelog note stating the minimum supported bazel versions coming with this change.

aignas avatar Dec 16 '25 14:12 aignas