Ahson Khan

Re-enable VS code analysis for live test pipelines once it is functional

1

It was disabled here since it wasn't working in VS 2022 (Windows 2022) legs: https://github.com/Azure/azure-sdk-for-cpp/pull/6024 cc @weshaggard, @danieljurek

From unrelated PR https://github.com/Azure/azure-sdk-for-cpp/pull/6024 on `ValidateLive Win2019_x86_with_unit_test_winHttp` https://dev.azure.com/azure-sdk/590cfd2a-581c-4dcb-a12e-6568ce786175/_apis/build/builds/4162693/logs/2709 ```text 2024-09-23T21:35:48.9249269Z test 467 2024-09-23T21:35:48.9250192Z Start 467: azure-core-amqp.TestSessions.MultipleSessionBeginEnd 2024-09-23T21:35:48.9250680Z 2024-09-23T21:35:48.9251755Z 467: Test command: D:\a\_work\1\s\build\sdk\core\azure-core-amqp\test\ut\Release\azure-core-amqp-tests.exe "--gtest_filter=TestSessions.MultipleSessionBeginEnd" "--gtest_also_run_disabled_tests" 2024-09-23T21:35:48.9252673Z 467: Working Directory: D:/a/_work/1/s/build/sdk/core/azure-core-amqp/test/ut 2024-09-23T21:35:48.9253442Z...

Reduce duplication in opening and reading the pem file for cert content in ClientCertificateCredential

1

`ReadPemCertificate()` already does open the file and read its contents. Can you make it so that x5c gets read as part of that process, instead of opening the file for...

Intermittent KeyVaultKeyClient.DoubleDeleteBeforePollComplete test failure due to 403 Reason: Forbidden

2

From https://github.com/Azure/azure-sdk-for-cpp/pull/5814 On: `ValidateLive Win2022_x86_no_rtti_with_unit_test` https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3971287&view=logs&j=2fc98781-9230-5004-8e4b-444d4f6ce9bd&t=3c1f81d9-4b69-5f1f-44df-3f6e046c3c5e ```text 2024-07-17T23:17:33.0085076Z test 22 2024-07-17T23:17:33.0085916Z Start 22: azure-security-keyvault-keys.KeyVaultKeyClient.DoubleDeleteBeforePollComplete 2024-07-17T23:17:33.0086337Z 2024-07-17T23:17:33.0087453Z 22: Test command: D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-keys\test\ut\Release\azure-security-keyvault-keys-test.exe "--gtest_filter=KeyVaultKeyClient.DoubleDeleteBeforePollComplete" "--gtest_also_run_disabled_tests" 2024-07-17T23:17:33.0089537Z 22: Working Directory: D:/a/_work/1/s/build/sdk/keyvault/azure-security-keyvault-keys/test/ut 2024-07-17T23:17:33.0090340Z 22: Test...

We recently introduced `BackupClient` in `azure-security-keyvault-administration`: https://github.com/Azure/azure-sdk-for-cpp/pull/5744 It should accept input urls as `std::string`, instead of `Azure::Core::Url` following the consistent pattern from the rest of the SDK clients. When the...

TransportAdapterOptions.DisableCrlValidation test is failing intermittently with a timeout error, on Win2022_Win32Api_debug_tests_winhttp_x86 and x64

3

The test is failing on an [unrelated PR](https://github.com/Azure/azure-sdk-for-cpp/pull/5139) with a timeout, both on x86 and x64 > Request error. Error Code: 12002: The operation timed out `Win2022_Win32Api_debug_tests_winhttp_x86` https://dev.azure.com/azure-sdk/public/_build/results?buildId=3246625&view=logs&j=85bfc3e6-dd05-5f88-257f-550486204084&t=744927fc-7997-531b-7e25-698f166ee20f ```text 2023-11-09T01:28:00.1647384Z...

Cleanup use of exploit or own within tests

1

See https://github.com/Azure/azure-sdk-for-cpp/pull/5085#discussion_r1376602678

would it make sense to use KV as a concrete example rather than `DoSomething` _Originally posted by @joshfree in https://github.com/Azure/azure-sdk-for-cpp/pull/4894#discussion_r1298617699_

Why do Credential types have ctor overloads that take both the TokenCredentialOptions and the derived/specific option type?

1

Why are there two initializers here, one which takes a TokenCredentialOptions and another which takes a WorkplaceTokenCredentialOptions (which is also a TokenCredentialOptions)? _Originally posted by @LarryOsterman in https://github.com/Azure/azure-sdk-for-cpp/pull/4872#discussion_r1291853951_