Ahson Khan

From https://github.com/Azure/azure-sdk-for-c/pull/2303#discussion_r941910653 Tests for: https://github.com/Azure/azure-sdk-for-c/blob/08fc01e15f9504acf7db2949a173dc07ed7c5067/sdk/src/azure/core/az_json_token.c#L334-L337 See https://dev.azure.com/azure-sdk/public/_build/results?buildId=1769797&view=codecoverage-tab

Consider a json_string_unescape method that has span as the destination and how much input validation is needed

1

**Current API:** https://github.com/Azure/azure-sdk-for-c/blob/c5238a6ba7ff1cdf645c2fec0cae07d762faf88c/sdk/inc/azure/core/az_json.h#L812 ```c // Null termination // Open question of how much validation to do AZ_NODISCARD az_result az_json_string_unescape( az_span json_string, char* destination, int32_t destination_max_size, int32_t* out_string_length); ``` Option 1:...

Intermittent vcpkg bootstrap failure: "Failed to download file", because "Timeout was reached" when downloading zlib from sourcefourge

1

From an unrelated PR: https://github.com/Azure/azure-sdk-for-c/pull/2250 Filing the issue to track how frequently we hit this issue to motivate further investigation. https://dev.azure.com/azure-sdk/public/_build/results?buildId=1678165&view=logs&j=a5fc39c3-d79c-51c5-1c7e-826b06cf306e&t=903cd952-2868-525e-140c-2f3f9f61951e > 2022-06-30T18:58:53.9350545Z Building vcpkg.exe... done. 2022-06-30T18:58:53.9350926Z 2022-06-30T18:58:53.9360261Z Telemetry 2022-06-30T18:58:53.9361203Z...

Rename live test matrix leg name to be more generic/general purpose rather than "with_iot_samples"

3

Right now the leg name has `iot_samples` in the name. Maybe it should be called `with_service_samples` or just simply `with_samples`. https://github.com/Azure/azure-sdk-for-c/blob/9f5a6334863ebbf214c6e2fbd5d6e3fce52fe0de/eng/pipelines/templates/jobs/archetype-sdk-tests.yml#L10 With storage support being added (granted it is currently...

Tracking issue to follow-up on https://github.com/Azure/azure-sdk-for-c/pull/1654#pullrequestreview-645033042

Add JSON parser and builder sample usage code snippets to an .md file as part of docs.

4

Start from the samples provided in the PR descriptions (barring any renames or API changes): https://github.com/Azure/azure-sdk-for-c/pull/871 https://github.com/Azure/azure-sdk-for-c/pull/902 https://github.com/Azure/azure-sdk-for-c/pull/1023 This seems like a good location for them: https://github.com/Azure/azure-sdk-for-c/tree/master/sdk/docs/core#azure-sdk-core-library-for-embedded-c cc @RickWinter, @JeffreyRichter

Take some action on the TODOs in source: - Some of these TODOs are minor code refactoring or optimization investigations that can be turned into issues - Otherwise, fix them...

Upgrade the vcpkg dependencies and commit used in CI and recommend in docs to latest available.

1

https://github.com/microsoft/vcpkg/releases The latest one currently available is 2020.11-1: https://github.com/microsoft/vcpkg/releases/tag/2020.11-1 Change this: https://github.com/Azure/azure-sdk-for-c/blob/0f00de05c05b86108a2d95016039954a2cd26dc4/eng/vcpkg-commit.txt#L1 Other than validating that CI works, as part of this change, also update the component governance, as needed:...

CI pipelines need step building with cmake 3.10

1

We expect the SDK to be buildable for customers and work with cmake 3.10: https://github.com/Azure/azure-sdk-for-c/blob/a82520bc0ea03a8de22ecc4f99206dcf1c18a45a/CMakeLists.txt#L4 Having a pipeline step that verifies this works would be great. https://dev.azure.com/azure-sdk/public/_build/results?buildId=1251956&view=logs&j=bd7cfc7a-9e05-507b-5103-65c9a747e93d&t=1b156c19-3f27-5a7d-f3ba-6e75c342737c Currently, most of...

Follow-up from https://github.com/Azure/azure-sdk-for-c/pull/1909#pullrequestreview-749716551 https://dev.azure.com/azure-sdk/public/_build/results?buildId=1087628&view=results  Once we are green, we should consider turning the spell check warnings into errors, so we stay green. cc @antkmsft, @danieljurek