Rename live test matrix leg name to be more generic/general purpose rather than "with_iot_samples"

[ahsonkhan]

Right now the leg name has iot_samples in the name. Maybe it should be called with_service_samples or just simply with_samples. https://github.com/Azure/azure-sdk-for-c/blob/9f5a6334863ebbf214c6e2fbd5d6e3fce52fe0de/eng/pipelines/templates/jobs/archetype-sdk-tests.yml#L10

With storage support being added (granted it is currently in a feature branch), it is a bit confusing to see those samples under iot related name.

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1187023&view=logs&j=437eda56-6549-565d-5141-89d54d1c1c74&t=be8930a4-c8ca-5981-39a3-9e0e1a7cda3f

https://github.com/Azure/azure-sdk-for-c/blob/bfca1f1d9ffe320f7d9d5ea448b4788f9d974347/eng/pipelines/templates/stages/archetype-sdk-client.yml#L24-L26

cc @antkmsft

[antkmsft]

I'd drop "with_samples" - one test may chose to do live testing via samples, other one may not. The goal is to live test, so if some sample is not able to be run as a live test, I think it will ultimately be excluded, proving that the main intent is to "run live test", but whether "with samples" or not, is a secondary detail.

[ahsonkhan]

cc @danewalton since this rename happened as part of: https://github.com/Azure/azure-sdk-for-c/pull/1608

[kurtzeborn]

Seems pretty low priority. EngSys team will not get to this. If this is important to the C team, feel free to make these changes.

[github-actions[bot]]

Hi @ahsonkhan, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.