Ahson Khan

Results 106 comments of Ahson Khan

This failure might be related, on MacOS: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1678165&view=logs&j=e3a64eae-3ca2-515e-3e44-1207c46c3ba5&t=1b9ced73-614e-5671-7440-5a208be067b9&s=6884a131-87da-5381-61f3-d7acc3b91d76 > 2022-06-30T19:03:17.5733870Z ##[section]Starting: Publish failed bom_manifest_$(BomArtifactName) Artifacts 2022-06-30T19:03:17.5749340Z ============================================================================== 2022-06-30T19:03:17.5750030Z Task : Publish Pipeline Artifacts 2022-06-30T19:03:17.5750990Z Description : Publish (upload) a file...

cc @danewalton since this rename happened as part of: https://github.com/Azure/azure-sdk-for-c/pull/1608

@barcharcraz - thoughts? Do we lose anything from bumping it? Its 3.10 atm. https://github.com/Azure/azure-sdk-for-c/blob/a694dabf75e09405bfcb160d82f353386ed7fcf0/CMakeLists.txt#L4 We recently started using `add_link_options()` anyway (cc @danieljurek, as part of https://github.com/Azure/azure-sdk-for-c/pull/956) https://github.com/Azure/azure-sdk-for-c/blob/356e4ddf9f4e2ac2a74f736b6c9e4de7e3cd19fb/sdk/tests/iot/common/CMakeLists.txt#L14 cc @vhvb1989, @RickWinter

@danieljurek - this is related to https://github.com/Azure/azure-sdk-for-c/issues/1170 which is assigned to you. Depending on the fix for `add_link_options`, this issue might just need to be closed without any other action.

I haven't looked at this issue for quite a while, so its unlikely this will be ready, unless we want to prioritize it. Let me know and I can take...

Deferring to future for now until we see any customer concerns related to this, to motivate re-investigating further.

I ran the linter across our repo before GA, yes, but we should leave this issue open until that has been added to CI for automated checks.

@danewalton let me know the before/after for code size if you notice a large spike in either direction.