Adam Gent

Results 165 comments of Adam Gent

Oh btw I'm not sure how to fix Sonar. Apparently the new annotations (`@NonNull`) give off more warnings mostly with builder like setters that return `this`.

Another thing I found while upgrading checkstyle (it has problems with module-info) is that `io.jooby.ServerSentEmitter.KeepAlive` is public. When you have a class inside an interface it is always public if...

N.B. The tests module (maven module) was using the same package as core jooby of `io.jooby`. I moved those to `io.jooby.test` which was a PITA because the refactoring broke. https://github.com/jooby-project/jooby/pull/2634/commits/7cab9ffca0b294f1b3b135acc115651e68093408

Alright the build seems to be working. Here is the module info for jooby: https://github.com/agentgt/jooby/blob/jooby_module-info/jooby/src/main/java/module-info.java The biggest issue is Kotlin and ASM. Those `requires` should be `requires static` which is...

> @agentgt isn't a jakart.annotation replacement for javax.annotation? I prefer to not add spotbugs or jspecify. @jknack I might have picked that but Kotlin does not work with it: https://kotlinlang.org/docs/java-interop.html#nullability-annotations...

Yeah we can revisit the null annotations later. The `TYPE_USE` ones (jspecify, checkerframework, eclipse and intellij's annotations) generally require an annotation in `package-info.java` on every package. The default in those...

@jknack Can we perhaps make another github issue(s) for doing the other Jooby extensions (aka the stuff in `jooby-project/modules`)? @imeszaros I made a starter project called mod-starter. (btw lots of...

I think the canonical approach I have seen is to use the TLD. I heard there was some talk of even sonatype (aka maven central) recommending that you use the...

I wonder why Spring did that. I have not used Spring 6 yet. I would be surprised if all the downstream Spring projects do that. I don't blame you though....

> Does it add value? I don't think so. It is exceptionally valuable for us as it was easily possibly in Spring and others. Look at the bottom of this...