Andreas Fabri

Results 468 comments of Andreas Fabri

> > [Here](https://github.com/CGAL/cgal/blob/50219fc33bc53b5846e9a4257befc6baef3f395a/Convex_decomposition_3/include/CGAL/Convex_decomposition_3/Single_wall_creator.h#L257) we have the assertion as first line of a function. > > git blame says that the code is 16yo and from Peter. So basically it was...

@sloriot any idea what the function [`initialize_index_map()`](https://github.com/CGAL/cgal/blob/119bd102c9f8d77dc80d09f827381c504dba1490/BGL/include/CGAL/boost/graph/internal/initialized_index_maps_helpers.h#L84) is about? I do not see it used anywhere. Do we have it for backward compatibility?

@MaelRL [here](https://github.com/CGAL/cgal/blob/119bd102c9f8d77dc80d09f827381c504dba1490/Periodic_3_triangulation_3/include/CGAL/Periodic_3_triangulation_3/internal/Periodic_3_triangulation_iterators_3.h#L89) I would prefer to see added the `case T::NONE` which is the default. Can it by construction not be `NONE`? Then I will put `CGAL_unreachable()`

@MaelRL does "meaningless" [here](https://github.com/CGAL/cgal/blob/119bd102c9f8d77dc80d09f827381c504dba1490/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/locate.h#L1193) that this cannot happen for whatever input, or does it mean that the user called `locate()` with illegal input?

Do I get it right that the problem shows with the above minimal code compiled with `cgal/main` ?