Andreas Fabri

Results 94 comments of Andreas Fabri

The warnings are not in Eigen, but triggered by how you use Eigen. When you write `const int pointsCount(features.cols());` you get the warning `warning C4244: 'initializing': conversion from 'Eigen::EigenBase::Index' to...

I just realized that you already try to silence it using `SYSTEM` for `include_directories` and Eigen, so probably I should switch to the latest version of VC++? You could have...

Just discovered `$GKlib_PATH`.

You might write `typeid(..).name()` and compare that to something pre-registered. I am not sure that it makes sense to check for potential bugs in a compiler.

Maybe you do that already, and I didn't realize it, but could we not also call the operators with non-matching types and then the compiler issues the error message with...

The data files have a problem with rights. I think they also need o+r But more importantly they should be in the package [Data ](https://github.com/CGAL/cgal/tree/master/Data/data) so that we do not...

@MaelRL as you recently cleaned up CMakeLists.txt files in a PR: Are my additions concerning Eigen needed or not. Apparently @JulyCode does not need them. And note that I removed...