Andreas Fabri

Results 468 comments of Andreas Fabri

I know that it is not a mistake introduced by this PR, but can you add the `typedef` for `FT` [here](https://cgal.github.io/9158/v1/Triangulation_on_hyperbolic_surface_2/classHyperbolicSurfaceTraits__2.html)

And a typo "reprensenting" [here](https://cgal.github.io/9158/v1/Triangulation_on_hyperbolic_surface_2/structCGAL_1_1Delaunay__triangulation__attributes.html) Also there should not be text in red in the User Manual

"\f$ \varepsilon \f$-net" as that in the html [here](https://cgal.github.io/9158/v1/Triangulation_on_hyperbolic_surface_2/classCGAL_1_1Delaunay__triangulation__on__hyperbolic__surface__2.html)

> And a typo "reprensenting" [here](https://cgal.github.io/9158/v1/Triangulation_on_hyperbolic_surface_2/structCGAL_1_1Delaunay__triangulation__attributes.html) > > Also there should not be text in red in the User Manual I think I got it. Red means what you added...

You must add Kernel_23 in the [dependencies ](https://github.com/camille-lanuel/cgal/blob/Triangulation_on_hyperbolic_surface_2-Delaunay_triangulation_class-camille-lanuel/Triangulation_on_hyperbolic_surface_2/doc/Triangulation_on_hyperbolic_surface_2/dependencies) file

> > You must add Kernel_23 in the [dependencies ](https://github.com/camille-lanuel/cgal/blob/Triangulation_on_hyperbolic_surface_2-Delaunay_triangulation_class-camille-lanuel/Triangulation_on_hyperbolic_surface_2/doc/Triangulation_on_hyperbolic_surface_2/dependencies) file > > Kernel_23 is already in /package_info/dependencies. Do you mean to add it in /doc/dependencies ? Yes, because you...

Is there really something to discuss? I guess it must be dealt with case by case and cannot be a global replace.

After an assertion we in general still return something in case the function has a return value. Is this also the case when replacing with the unreachable statement?

Can a `default:` in a `switch` be at the very beginning (see [here](https://github.com/CGAL/cgal/blob/7570ad8a43994b2890f0172293f48e69ca803672/Periodic_2_triangulation_2/include/CGAL/Periodic_2_Delaunay_triangulation_2.h#L475))? Does it then still go to the other cases?

Do you agree that we make [this](https://github.com/CGAL/cgal/blob/7570ad8a43994b2890f0172293f48e69ca803672/Periodic_3_mesh_3/include/CGAL/Periodic_3_mesh_3/Protect_edges_sizing_field.h#L1099) to a `CGAL_assertion_msg()`? With assertions switched off, we then no longer see something on `cerr`, but that is not desired anyways.