Andreas Fabri

Results 468 comments of Andreas Fabri

Is it really needed for vertex and face ? The map stores what ?

@soesau to make it self contained can you just add at the top of the _Conversation_ page what the problem was.

> What do you think of `apply_iterative_snap_rounding()` ? cc @MaelRL I do not like an `apply_` prefix. Did you have a look at the [existing function for 2D](https://doc.cgal.org/latest/Snap_rounding_2/group__PkgSnapRounding2Ref.html)

Errors in [CGAL-6.2-Ic-48](https://cgal.geometryfactory.com/CGAL/testsuite/summary-6.2-Ic-48.html?package=Polygon_mesh_processing)

`clang: error: unknown argument: '-fexperimental-library'` in [CGAL-6.2-Ic-35](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-35/Constrained_triangulation_3/TestReport_magritte_arm64-apple_bigsur_clang1200-release-64bits.gz)

VC2017 has a problem in the testsuite [CGAL-6.2-Ic-40](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-40/Constrained_triangulation_3_Examples/TestReport_Christo_MSVC2017-Debug-64bits.gz) with `#include ` which is C++20. [link](https://en.cppreference.com/w/cpp/header/version.html)

clang on apple reports an [error](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-40/Constrained_triangulation_3/TestReport_magritte_arm64-apple_bigsur_clang1200-release-64bits.gz) concerning `finite_facets_end()`. Is this a missing `using` statement in the derived class? Why only this compiler?

There is also a [warning ](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-40/Constrained_triangulation_3_Examples/TestReport_magritte_arm64-apple_bigsur_clang1200-release-64bits.gz)suggesting adding braces.

The gdb stuff, can you confirm that this does not make our algorithms and data structures read or write anything in files or streams. And that it does not require...

What is the status of this pull request ?