Andreas Fabri
Andreas Fabri
Warning in[ I-c-337](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0.1-Ic-337/Basic_viewer_Examples/TestReport_lrineau_Fedora-rawhide.gz)
Concerning `CGAL::assume()` it is unlucky that it has not the same semantics as `[[ assume ]]`. We have probably not many users of `CGAL::assume()` so do we want to break...
@sloriot this is no longer WIP.
@sloriot what has to be approved?
> What I don't like with `CGAL_unreachable()` replacement is that if there is a bug in CGAL code and that we reach a place marked as unreachable no assertion will...
@GilesBathgate your reasoning makes sense. Did you close the PR out of no-reply-fatigue ?
Going up in the call stack we find [this comment](https://github.com/CGAL/cgal/blob/9601e967245681fa5344488cbceebd955050e087/Nef_3/include/CGAL/Nef_3/SNC_external_structure.h#L869). Reading it, just skipping is maybe not the right solution.
@citystrawman can you please put a self contained example on gist.github.com so that we can reproduce/fix. You refer to an example, but the [example for stitching](https://doc.cgal.org/latest/Polygon_mesh_processing/Polygon_mesh_processing_2stitch_borders_example_8cpp-example.html) uses `Polyhedron` and not...
Can we then add an option in the `CXX_FLAGS` related to `-Wsfinae-incomplete` ?
Hello @CheLamVien , you may have seen that Laurent has provided a fix in PR #9178 . Let us know if it works for you.