CGAL
Nef_3: Use the skipVEL parameter to ensure result is always an SFace
Summary of Changes
This sets the skipVEL (Skip SVertices SEdges and SLoops) parameter to true, when calling the locate method in get_visible_facet of SNC_const_decorator. Since it's trying to locate an Sface, it makes no sense for locate to match SVertices, SEdges or SLoops, and if it does the assertion in get_visible_facet will fail.
Release Management
- Affected package(s): Nef_3
- Issue(s) solved (if any): #7271
- Feature/Small Feature (if any): bugfix
- License and copyright ownership: CGAL authors
As was previously stated:
In commit https://github.com/CGAL/cgal/commit/ebd5e00ba8e5041e64b415eb9421f89045591ac9 the value of true was passed to L.locate() which skips needless tests.
Applying the same change to the get_visible_facet method of SNC_const_decorator makes the assertion exception never occur. @afabri However I am not sure if it would be correct to apply the same change here or not.
@GilesBathgate your reasoning makes sense. Did you close the PR out of no-reply-fatigue ?
@GilesBathgate your reasoning makes sense. Did you close the PR out of no-reply-fatigue ?
I am unsure, but I will re-open.
Going up in the call stack we find this comment. Reading it, just skipping is maybe not the right solution.