Andreas Fabri

Results 468 comments of Andreas Fabri

Is it ok that I changed "\\" to "/" ?

> [The doc of FindBoost](https://cmake.org/cmake/help/latest/module/FindBoost.html) says "BOOSTROOT : preferred installation prefix" On my installation, it is set to where `BoostConfig.cmake` is, and it works But also with the underscore on...

Why do we have this cmake if-then-else [here](https://github.com/CGAL/cgal/blob/4305f01384659ecc200db2c41f41aa48d43e92d2/Ridges_3/examples/Ridges_3/CMakeLists.txt#L22)? Is it for backward compatibility for older versions of cmake? @lrineau

> > Why do we have this cmake if-then-else [here](https://github.com/CGAL/cgal/blob/4305f01384659ecc200db2c41f41aa48d43e92d2/Ridges_3/examples/Ridges_3/CMakeLists.txt#L22)? Is it for backward compatibility for older versions of cmake? @lrineau > > Yes, I think so. Maybe it can...

> Also can we then remove the line `add_definitions("-DCGAL_USE_BOOST_PROGRAM_OPTIONS")` ?? It is needed. Does that need "modernization" @lrineau ?

TBB seems also to use keywords like `emit()`, as can be seen in the CI ``` /usr/include/oneapi/tbb/profiling.h:229:15: error: expected unqualified-id before ‘)’ token 229 | void emit() { } ```...

There is a disussion on[ github/TBB](https://github.com/oneapi-src/oneTBB/issues/547). There I even saw @mglisse. My conclusion is that we just keep `QT_NO_KEYWORDS`

@lrineau what is `CGAL::Data` in `target_link_libraries()` about ?

Concering VTK it seems that we still have to link against [${VTK_LIBRARIES}](https://docs.vtk.org/en/latest/getting_started/index.html#using-c-and-cmake)

@soesau I think I also spotted some in the Orthtree package. Can you please handle them,