Adam Meehan

Results 52 comments of Adam Meehan

Thanks, but there was a bit too much in the PR and also didn't conform to the convention of using major version per ActiveRecord major version. I have pushed necessary...

I like this idea and wish it was in all attribute level validations. Is there any precedent of this anywhere else?

One of the goals of this gem is be more strict or 'correct' than the native Ruby Time behaviour. I would not consider your suggestion to be necessarily correct. The...

Yes that does seem too aggressive. I have also been reviewing the add `add_formats` throwing an error when format exists also. But `remove_formats` seems like an easier decision since it...

Oh damn, a leap year bug. I think advancing to March 1 would probably be the way to go. Need to think about it I guess.

Thanks but this needs some explaining. I'm not familiar with ActiveSupport::Callbacks::Callback. Are declaring it or monkey patching it? Why is method_source gem required as a dependency? Lastly please don't commit...

Simplified a few times. Offering this PR as a way to fix #810. Build will pass, just needs a kick again.

@unixmonkey thanks for testing. I don't use remotipart but had an infinite loop issue, which this PR solves. Seems the remotipart gem causes a variation this PR doesn't fix. I...

@unixmonkey I can see remotipart is trying to avoid different override techniques and just stick with aliasing. The causes a conflict if wicked_pdf uses prepend and remotipart is aliasing our...

It would good to add it as config and make it empty. Then instruct people to add it the initialiser names as required eg the remotipart one. That way we...