Adam Meehan

Results 36 comments of Adam Meehan

Thanks for this. One issue is that most of the translations do not belong in this gem. Month names etc. are handled by Rails. Please look a the English i18n...

Thanks! Looks good, though I had in mind to merge the ignore/raise/error into a single config setting. Then override the old setting accordingly. Something like this ``` ruby e if...

Thanks @timdiggins . Given you are loading the initializer explicitly I wonder if you are actually booting rails for these specs such the railties are loaded? The necessary step happens...

@timdiggins how did you go with this? was it confirmed in vanilla Rails?

Do you mind trying again against master? I changed the 'load_config_initializers' to symbol. I think I've run into this in the past. I will add a spec for this later.

@pedrofurtado are you able to share you `ValidatesTimeliness` initializer? Also, the version should match the major Rails version you are using. v5 is meant for Rails v5.x compat. The v6...

Can you add in this line and see if it makes any difference `config.parser.use_us_formats`

I imagine beta version would soon. Final depends on any issues and confirmed usage. I have no Rails 6 projects yet so I won't be using that version at the...

@pedrofurtado yep soon. once I have some feedback from others.

Do you have the plugin parser enabled in the initializer?