grouped_validations icon indicating copy to clipboard operation
grouped_validations copied to clipboard

Published 20 hours ago • verified publisher icon adzap

Rails 4 upgrade

Open jleonardw9 opened this issue 9 years ago • 8 comments

All specs passing, and this is currently working for Rails 4.2.4.

jleonardw9 avatar Sep 15 '15 23:09 jleonardw9

Thanks but this needs some explaining.

I'm not familiar with ActiveSupport::Callbacks::Callback. Are declaring it or monkey patching it?

Why is method_source gem required as a dependency?

Lastly please don't commit the Gemfile.lock.

adzap avatar Sep 15 '15 23:09 adzap

Ah, forgot to add Gemfile.lock to my .gitignore. Sorry about that. I'm going to look into trying to do away with using the method_source gem, or at least a rock-solid reason why it is needed. I'll get back to you on that. Thanks for the feedback!

jleonardw9 avatar Sep 17 '15 12:09 jleonardw9

Any update on this?

noahc avatar Oct 21 '15 13:10 noahc

I found another grouped_validations that claims to have worked for others on Rails 4.2.4 here: https://github.com/BroiSatse/grouped_validations/commit/49f634a655391aade53870ab4e7091d6605c2208

However, I can't seem to get it working. I keep getting undefined method 'group_valid?' for ....

noahc avatar Oct 21 '15 14:10 noahc

Yeah, turns out I was just being stupid. I was using the method_source gem for troubleshooting and didn't remove it when I was finished. I just pushed up the change and also removed the Gemfile.lock.

jleonardw9 avatar Nov 17 '15 20:11 jleonardw9

Ahh, thanks! Hopefully this can help a fellow traveler as well.

noahc avatar Nov 17 '15 20:11 noahc

I hope so! Sorry it took awhile to get back to you.

jleonardw9 avatar Nov 17 '15 20:11 jleonardw9

@adzap Any thoughts on getting this merged in?

akennedy avatar Jun 06 '16 22:06 akennedy