Adam Meehan

Just wondering if this line should be a `forEach` rather than `map`? https://github.com/jwadhams/json-logic-js/blob/c1dd82f5b15d8a553bb7a0cfa841ab8a11a9c227/logic.js#L380

See https://github.com/CanCanCommunity/cancancan/blob/959eee14e132b3f5e22b9e29649327eaf46efb37/lib/cancan/model_adapters/sti_normalizer.rb#L34 The `merge` presumes a hash of conditions but this raises error if the conditions are a relation.

Bit confused about releases

3

Don't mean to be a pain, but I am interested to review the changelog of each gem version released. I'm guilty of falling behind in the changelog of my own...

Handle PdfHelper include vs prepend with separate modules

16

As a solution to the current infinite loop issue, I've approached it by handling include vs prepend slightly differently so that you are just using `alias_method_chain` or `super` respectively. No...

Encapsulate PDF generation controller code in a renderer class

6

I'm having some issues with the latest release v1.2.0. In diagnosing I read through the gem code and saw quite a bit of method pollution in the base controller I'd...

Remove unnecessary Sequel refresh call in make

1

Hi Pete Sequel does a refresh by default for an inserted row, so there is no need for the explicit refresh in the Machinist adapter. Thanks Adam

Support increment/decrement

15

Any reason not to support these cache methods? I gather you don't use them so you left them out. Wondering if you want a PR for it?