Anton Driesse
Anton Driesse
>@adriesse Fair point. I can include just horizon.py and test_horizon.py in this PR. @JPalakapillyKWH Beware though, that my opinion is only one; there may be others...
I read the paper mentioned at the top of this PR and my impression is that there is not much overlap between the methods discussed there, and those programmed here....
Perhaps a good next step would be to add (or expand) Notes sections for the doc strings, where you explain the algorithms used, and give references to the sources you...
> This didn't effect the overall shape of the output elevation, just the size of the elevation angle. It seems to match up reasonably? closely to pvgis & the method...
Consistency would be great. I'm not a fan of really long names, but you already knew that.
I just came across `T0` and `E0` in `pvsyst_parameter_estimation`...
Perhaps only certain base functions need to be in pvlib per se, and the graphical analysis could go into one or more example notebooks?
I agree that appending more and more columns to a DataFrame may not be the best way. If you do need to do joins, there are rsuffix and lsuffix arguments...
Time flies! I think this is better for sure, but I think we need some more guidance from the maintainers here. Is it close enough to have a PR?
I guess I can't edit this myself, but I would like the spectral mismatch PR to go into this release because I would like to use the new functions in...