Anton Driesse
Anton Driesse
I had a funny feeling that using "set*" and "get*" might trigger an association with synonymous python constructs. I had previously used "from*" and "to*" and perhaps I should have...
Also, the `__call__()` function was kind of an afterthought and used for testing. It's small but it changes the class from a pure utility that's not part of a simulation...
>> how to evaluate what's better > I think what's easiest for the developers. I think the developers will be able to deal with much greater complexity than the average...
I'm not quite sure how to move toward a consensus here. I think perhaps the key to gaining acceptance for this particular class design is to really position it as...
Thanks very much, @kanderso-nrel. Perhaps if no one else has _strong_ objections, then we can move forward more-or-less as is? One way or another I need to bring this to...
Making multiple constructors would be ok with me. I had toyed with that early on, but thought using the single constructor I could better emphasize the difference between module properties...
Most or all of the bottom layer functions work with scalars and I think that's important. May be less so for the classes, but still desirable.
You could perhaps just use the solar constant as `dni_extra` when all else fails. Then you don't need to raise anything.
Good discussion. There are data and PAN files from CFV labs here if it useful: (https://pvpmc.sandia.gov/pv-research/pv-lifetime-project/pv-lifetime-modules/)
After rereading this long-forgotten thread, I wonder whether @cwhanse got any clarification or confirmation from Bruno and/or Ken... @markcampanelli do you find that this exponent gives you a useful degree...