Anton Driesse
Anton Driesse
Looking forward to your review @markcampanelli !
And others' reviews too of course...
@mikofski would you be available to do a review since you are familiar with the subject?
Empty module: ```mismatch```. I anticipate some more broadly usable functions could find a home here over time, so a more generic name might be considered.
So we will probably have some interesting discussion on the type and shape of the outputs. While working on this I noticed that spectrl2 has wavelength as the first dimension....
Yes, I think it would make some sense to move those two functions. At the moment I can't imagine ```spectrum``` growing a lot more.
I've been thinking about numpy friendliness here, and I am tending toward making these functions pandas only. The wavelength values are an integral part of the data so it makes...
Ok, I think it works now. :)
I think this is ready for review. Not sure whether I cause all the automated test failure--I hope not.
Should I try attempt to change [docs/sphinx/source/reference](https://github.com/pvlib/pvlib-python/blob/master/docs/sphinx/source/reference), or leave that to someone more familiar with this?