Anton Driesse
Anton Driesse
It turns out that ```term1``` in ```fedis_diffuse()``` is exactly the same as the weighting function w in ```fedis()```, just in simplified form. I suggest making the code the same in...
I don't think ``singlediode()`` is the right hierarchy level for verifying algorithms and implementations. I would prefer to see functions like ``Voc()``, ``Isc()``, and especially ``MPP()`` in addition to ``I_from_V()``...
Perhaps we should define the allowable range for each of the parameters of the gold implementation. I think such ranges should extend beyond what the module database contains for commercial...
Extinction in the glass is negligible so we can ignore that part. The point is that when the original Schlick reflectance function is changed to a normalized iam function, the...
Please note that I have expanded this feature request to include a function for the diffuse iam factors. These two functions could in fact be done in a separate PR...
What do you think, could the module go in pretty much as-is, or should it be organized differently?
> So for this base layer, I'd favor a new module e.g. `pvlib.dc_efficiency.py` and I immediately dislike the name. I dislike that name too. :)
In terms of priorities, I would see API as number one and the rest as nice to have.
Is the clipping published? What problems does not clipping cause?
bifacial.infinite_sheds.get_irradiance_poa: use of height to pitch ratio instead of height and pitch
A superficial reading of these issues brings to mind the atan2 function. Sometimes two arguments are better than one. Anyway, GCR=0 means no PV to me!