Anton Driesse
Anton Driesse
@cwhanse The constant and the method to calculate sun-earth distance are independent of each other. The constant probably only matters for the clear-sky models, where the best value to use...
I'm getting the ball rolling on this PR because there is some overlap with #1354 and it may be better to think ahead about how to best sort this out...
> I agree we should unify coding into sensible locations as soon as possible. > > 1. mpm fits not just the performance ratio but also other normalised coefficients such...
Well, maybe my opening suggestion was not the best in light of mpm/mlfm being used with a gradually expanding number of predictors and also applied to a multiple response variables....
Should/does fedis direct be equal to schlick? If not, why not?
> Close-ish but not identical. FEDIS is using the true Fresnel equations for the direct component I see, but we already have that in iam.physical, right?
> FEDIS has the option to normalize the IAM profile with respect to another device with a different index of refraction. Normally IAM is a property or characteristic of one...
> > Should/does fedis direct be equal to schlick? If not, why not? > > Close-ish but not identical. FEDIS is using the true Fresnel equations for the direct component...
Nicely done. Let's see what other comments appear here over the coming days... On a related note, I think it would be great if the original author could submit two...
Perhaps we should invite a additional reviewer on this one?