Adrian Moisey

Results 168 comments of Adrian Moisey

Whoops, this one slipped through the cracks, sorry! I left a nit, but I think it's good so far

/area cluster-autoscaler /area vertical-pod-autoscaler

As per this suggestion: https://github.com/kubernetes/ingress-nginx/issues/7442#issuecomment-1382226161 Would you accept a PR truncating the name to 52 characters? I'm happy to make that change if needed.

Does it make sense to add some sort of validation? If some names are longer than allowed, get Helm to bail out?

/area vertical-pod-autoscaler

@kevinteng525 sorry that this slipped through the cracks. We should have capacity to review and approve now. Are you still around to help push it forward?