autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

VPA: Add tests for the recommender metrics utilities

Open chansuke opened this issue 6 months ago • 4 comments
trafficstars

What type of PR is this?

/kind feature

What this PR does / why we need it:

add tests for the recommender metrics utilities

Which issue(s) this PR fixes:

Fixes #8128

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


chansuke avatar May 19 '25 14:05 chansuke

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar May 19 '25 14:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke Once this PR has been reviewed and has the lgtm label, please assign omerap12 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 19 '25 14:05 k8s-ci-robot

/triage accepted

omerap12 avatar Jun 02 '25 05:06 omerap12

cc @voelzmo

omerap12 avatar Jun 03 '25 16:06 omerap12

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 03 '25 08:10 k8s-triage-robot

Whoops, this one slipped through the cracks, sorry! I left a nit, but I think it's good so far

adrianmoisey avatar Oct 04 '25 05:10 adrianmoisey

/remove lifecycle/stale

omerap12 avatar Oct 04 '25 12:10 omerap12

/remove-lifecycle stale

omerap12 avatar Oct 04 '25 12:10 omerap12

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 14 '25 23:10 k8s-ci-robot

@chansuke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-autoscaling-e2e-vpa-actuation c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 link true /test pull-autoscaling-e2e-vpa-actuation
pull-autoscaling-e2e-vpa-updater c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 link true /test pull-autoscaling-e2e-vpa-updater
pull-autoscaling-e2e-vpa-admission-controller c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 link true /test pull-autoscaling-e2e-vpa-admission-controller
pull-autoscaling-e2e-vpa-recommender c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 link true /test pull-autoscaling-e2e-vpa-recommender

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Oct 31 '25 08:10 k8s-ci-robot