autoscaler
autoscaler copied to clipboard
VPA: Add tests for the recommender metrics utilities
What type of PR is this?
/kind feature
What this PR does / why we need it:
add tests for the recommender metrics utilities
Which issue(s) this PR fixes:
Fixes #8128
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chansuke Once this PR has been reviewed and has the lgtm label, please assign omerap12 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/triage accepted
cc @voelzmo
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Whoops, this one slipped through the cracks, sorry! I left a nit, but I think it's good so far
/remove lifecycle/stale
/remove-lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@chansuke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-autoscaling-e2e-vpa-actuation | c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 | link | true | /test pull-autoscaling-e2e-vpa-actuation |
| pull-autoscaling-e2e-vpa-updater | c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 | link | true | /test pull-autoscaling-e2e-vpa-updater |
| pull-autoscaling-e2e-vpa-admission-controller | c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 | link | true | /test pull-autoscaling-e2e-vpa-admission-controller |
| pull-autoscaling-e2e-vpa-recommender | c6aa674ad78e6df29c9bed61e0fd8c7375ea6ab9 | link | true | /test pull-autoscaling-e2e-vpa-recommender |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.