Adrian Moisey

Results 167 comments of Adrian Moisey

I'm not too sure really. Let me hack away and see if I can get it working, I imagine it won't be too hard. Then you can decide if it's...

I don't think so. We do use the `--metrics-per-host=false` option The particular tag we're worried about is `service`, which is the backend service that is bring routed to, not the...

> Can you test with /test as a specific path and see if the issue is the same? There may be an issue with pathType and the same path, /,...

I think I understand what is happening here. I plan to submit a PR if that is fine with you

> Can you post the link proof from upstream K8S KEP, that clarifies, that identical host joined with identical path, is allowed to be a individual new rule, just because...

> Also, from the point of view of benefit to mass of users, admission-webhook should not allow duplicates. > > I do understand that temporary duplicates help in migration as...

> According to the tag controller-1.10.1 the file nginx.tmpl should support the Custom-Headers functionality implemented in #9742. But it does not. I'm curious about this. I've looked at the release...

> According to that controller tag the controller image should contain that feature. https://github.com/kubernetes/ingress-nginx/blob/controller-v1.10.1/rootfs/etc/nginx/template/nginx.tmpl Oh right, I thought you meant that the tag's description (well, release) contains the feature. Yeah,...

The history of `rootfs/etc/nginx/template/nginx.tmpl` for https://github.com/kubernetes/ingress-nginx/blob/release-1.10/rootfs/etc/nginx/template/nginx.tmpl vs https://github.com/kubernetes/ingress-nginx/blob/controller-v1.10.1/rootfs/etc/nginx/template/nginx.tmpl is definitely different.

Hey @britdm, are you planning to continue this PR? If not, do you mind if I try work on it?