Alan Donovan

Results 347 comments of Alan Donovan

Let's stick with the subset of fields Tim [proposed](https://github.com/golang/go/issues/66315#issuecomment-2004981443): {Path, Version, GoVersion}; the rest are more obscure. We can always add more later when a clear need arises. I've appended...

> I thought not-nil was being proposed for the actually-there-is-no-module... (I assume you mean "nil" here.) I think reporting partial information may be ok, but "nil" cannot mean exactly "there...

See also https://github.com/golang/go/issues/66175, in which I request a better error message about a missing patch version suffix.

> While working on gopls, we have a few places where (for example) `*ast.Object` or `*ast.Scope` are handled in a type switch or type assertion, and the `deprecated` analyzer produces...

@laurentlb I agree with all three points.

I think the spec should be changed to say"if x refers to a list and y is also a list..." to reflect our current intention. There remains the question of...

My preferences: > Choice: if y is an iterable, is it equivalent to x.extend(y)? Yes. It's useful, and consistent with the behaviors of both x.extend(y) in Starlark, and of x...

You're absolutely right, I neglected the `select` case entirely. The fallback (as implemented by Go) seems like the right behavior, if the test of y for `iterable` (as also implemented...

> Conversely, allowing them seems harmless. Not harmless: it has a complexity cost, and the lexer is already complicated. > From what I can tell, standard UTF-8 passes a decoded...

Bazel, which uses the Java implementation of Starlark, has a [BUILD-file debugger](https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/starlarkdebug/server/StarlarkDebugServer.java;l=31;drc=4eb62cd07393e495ab9ead49b771871d1050ee51;bpv=1;bpt=1), which uses some [hooks](https://cs.opensource.google/bazel/bazel/+/master:src/main/java/net/starlark/java/eval/Debug.java;drc=4eb62cd07393e495ab9ead49b771871d1050ee51;bpv=1;bpt=1;l=32) in the interpreter, but there is no debugger for pure Starlark outside of Bazel....