Alan Donovan
Alan Donovan
I'd be happy with lists of strings (filenames), parallel to TestFiles and OtherFiles. That avoids the tricky interaction with the NeedSyntax mode bit.
@timothy-king & @lfolger, does the `TestOnly bool` API address your needs?
> I recall @adonovan used a GOPLSCACHE mechanism to help with that in the previous infrastructure ([CL 494297](https://go.dev/cl/494297)). I'm not seeing that in the LUCI infrastructure—perhaps it needs to be...
> Is the TMPDIR set in the builds sufficient? That gets cleared after every run. Yes, a temp directory that lasts for a complete run of tests at a single...
Sounds good. The current crashmonitor never lives much longer than the parent (application) process because the termination of the parent--for any reason--closes the pipe, causing the ReadAll in the child...
If the interface is to be based on the set of methods actually used, as opposed to all those defined, then this requires a global query on the field, analogous...
The feature is unlikely to work well until comment support is improved, but comment support will improve this year, so I don't think it should stop you from contributing this...
Thanks @golopot for contributing this feature--and sorry for the review process took so long!
@findleyr, I can reproduce this with go@master and gopls@master. Much though I would love to have fixed this by accident in CL 542057, I don't think I can take credit...
See https://go.dev/cl/554495 for a quick prototype implementation and preliminary results.