Alan Donovan

Results 347 comments of Alan Donovan

There are two problems here: 1. Checker.fileFor panics if given an non-zero ("IsValid") but actually invalid pos. It should probably just return nil. 2. The AST contains a CallExpr whose...

Realistically, any fix for this will involve changes to go/ast, go/parser, and go/types, which are in the pre-go1.23 freeze right now. Pushing this off to gopls 0.17, assuming the tree...

I suspect the directive analyzer handles `//go:debug` comments this way for consistency with `//go:build` comments, which are "ignored adjoining the package declaration": ```go // A +build comment is ignored after...

Good question. Perhaps these functions shouldn't presume which LSP client is in use, but should query (waved hands vigorously) whether the buffer is managed by eglot or lsp-mode and take...

I would love to see this feature implemented. My immediate need is that it would be nice when editing a test--which in Go is a `func TestFoo(t *testing.T)`, but most...

I can still reproduce this problem using eglot v1.15 and gopls v0.15. I can also reproduce it with VS Code, so it's definitely at least partly a gopls bug as...

See also https://github.com/microsoft/language-server-protocol/issues/1911

@hyangah fixed it in https://github.com/golang/go/issues/67225, I think.

> The vs code editor will flash posibilly when save .go files remotely What do you mean by "flash"? A visual flicker in the UI? And what do you mean...

That is very strange. Can you please share the log you see in the gopls output? ![Screen Shot 2021-01-27 at 2 53 49 PM](https://user-images.githubusercontent.com/4999471/106151310-3899a680-614a-11eb-9be7-42f2ae0592c9.png)