Andy Dienes

Results 134 comments of Andy Dienes

> `combine(df, :x => collect∘extrema => :free_col, Over(:x => sum, :id))` > and now it is unclear what should be done. so, I would say this should error for the...

I think in terms of behavior, this does more or less everything I'm imagining (although obviously the implementation is inefficient and the API is pretty kludgy) ``` function Over(expr, col)...

> [`Over` with] `combine` is more tricky than `select` and seems less useful totally agreed. in fact, part of the whole reason to want `Over` is explicitly to map the...

I still think my preferred syntax, if possible, would be with a pipe, both to avoid an extra layer of function nesting and to avoid the classic problem of having...

yes, that looks great IMO. `Over(A, GROUPING_COLS) => B => C`. also seems reasonable if you want to avoid the currying

also an option to both double indent _and_ newline when the signature spans multiple lines, which would be my first choice.

why is https://github.com/domluna/JuliaFormatter.jl/issues/741#issuecomment-1607500407 off the table? it sounds like that's a bug in VSCode extension not a fundamental problem with the format

in this case, it's not really "repeated sampling" in the same sense as most other samplers, as this represents a _single_ draw from a `Multinomial` , which just so happens...

if the idea looks ok I'll go fix all the tests and such, just wanted to hold off on that if this cannot be merged for other reasons

benchmarks of 4 different attempts to multinomial sampling. status quo is more or less equivalent to `binom` column here, which calls `multinom_rand!` so there is definitely opportunity to do a...