Andy Dienes

Results 134 comments of Andy Dienes

is there a reason the docs enforce specifically a `Vector{UInt8}` from `serialize` rather than an iterator over `UInt8` ? it's quite rare one needs indexed access to serialized data, right?...

the bug being that `map` assumes that mutating the result of `getindex` at some location will mutate the value in the collection? that sounds ... reasonable. maybe `map(::StructArray)` should return...

well, to be honest I'm not sure that I'd say the `AbstractArray` interface is defined precisely and explicitly enough such that it's even possible to adhere to it "perfectly" I...

I just spot-checked `LazyArrays.BroadcastArray` and `MappedArrays.MappedArray` (not pretending to be an exhaustive review) and you are right it seems neither of these types satisfy `arr[idx] === arr[idx]`. although also neither...