Andy Dienes

Results 134 comments of Andy Dienes

what is the advantage over https://github.com/JuliaLang/julia/pull/57507 ? this seems to add quite a bit more complexity and includes scary things like hardcoded constants

not sure if I'm 100% qualified to review beyond stylistic things but as far as I can tell I like this approach it might make sense to run the benchmarks?...

what would be the plan if someone comes along and complains that their promotion didn't converge? I would probably be of the opinion that if there's going to be a...

the original motivation for static ints as I understood it was mostly stuff like ranges and shapes; you seem to have used them here almost exclusively to reimplement arithmetic and...

> The motivation is numeric/symbolic accuracy, e.g. the linked issue for the defining identity for one for irrationals. yes, I saw the issue with `one`. but this feels like an...

> I am mostly interested in it for the BigInt type for which `x % n` allocates, and so `x % n == 0` is not cheap, whereas it is...

`BigInt` are officially immutable though (despite the fact that they are mutable in practice) so one could return `big"0"` or any other shared obj and allocate only exactly once per...

to be applied after / on top of https://github.com/JuliaLang/julia/pull/55318

oops, I missed some of the previous prs here. I may have duplicated some effort then