Andy Dienes
Andy Dienes
``` circshift2(t::Tuple{L,R}, shift::Integer) where {L,R} = ifelse(iseven(shift), t, reverse(t)) ``` is a bit faster on my machine than the length-2 implementation added here (just `ifelse` vs `if-else` mostly. not sure...
I believe this is intended see also: https://github.com/JuliaLang/julia/issues/32528
wasn't it originally `wrap` then reverted? https://github.com/JuliaLang/julia/pull/53896 I might be conflating issues together, didn't follow super closely
not sure I would use the word "works", as this seems worse behavior than before to me of course `unsafe_copyto!` can do whatever it wants, but using `copyto!` I'd really...
I don't think we need three methods here. On second look I'm not sure the `NTuple` approach really makes a difference, @ararslan maybe could you help clarify exactly what the...
as far as I can tell, this would be the first usage of `__safe_getindex` anywhere in the entire Julia source code. I empathize with the desire for maximum performance, but...
that makes sense to me. I think you have looked at the benchmarks a lot more carefully than I so I trust whatever conclusion you arrive at. (I'll note that...
if you remove the `::AbstractArray` methods I suspect you will find more success with the remaining components of the PR. I still feel like those are unnecessary to add
agree preferable IMO to retain transitivity one can always strip/empty the annotations before comparing
not trying to minimize the issue, but just noting that if one finds themselves with many small vectors and a need for speed, probably a `Tuple` or `SVector` is a...