Adam Jermyn
Adam Jermyn
The alternate input format for einsum (i.e. `einsum(op0, sublist0, op1, sublist1, ..., [sublistout])`) produces an error if the number of tensors grows too large. The error also changes with the...
## Intro I've been trying to understand what makes `state` so tricky in MESA/`star`. This is my attempt at expressing what's wrong, and what we might do about it. Everything...
Will Schultz (@wcschultz) and I have been working to implement some of the results from his recent paper analyzing 3D RHD simulations (https://arxiv.org/abs/2009.01238) in MESA, and are doing this through...
@orlox suggested that we impose a (smooth) limit on the convection speed in TDC, and implemented this in the `tdc_gamma_no_cs` branch. I'd just like to have a bit of discussion...
The comments in the inlist say this was generated by running `make_co_wd` with an initial mass of `4.1`. I just tried this on `9e988c4` and hit a `max_model_number` termination in...
The `ns_he` test case fails with TDC on. The latest commit where I’ve checked this is `c351d55`. I’ve been working on this the last few days and my best theory...
Per Bill P (mildly edited into an issue): In MESA we scale equations. Currently this does two jobs: 1. It makes the equations dimensionless. 2. It decreases the magnitude of...
There is an open TODO listed in job/run_star_support.f90 on line 3142: ``` ! get nearest value matching xq for the composition TODO: interpolate ``` Is this an enhancement? A bug...
In hydro_temperature on line 111 there’s a commented out expression: ``` !d_P_rad_expected = d_P_rad_expected*s% gradr_factor(k) !TODO(Pablo): check this ``` I have no idea what needs to happen here, but I’m...
Also make `auto_diff` python generator ensure that `auto_diff_star_num_vars` gets automatically updated.