Adam Jermyn
Adam Jermyn
I think using -huge(int) is a good plan. We could also add an is_bad interface that supports integers and just checks for the -huge(int) value. -Adam On May 31, 2020,...
If we do this I suggest we don't call it `set_nan` and instead call it `set_bad`. Then it's clearer that we're setting bad values (which means NaN for reals but...
Uhhhhh a lot has changed in the code handling MLT since then. Not sure how useful bisecting is here. Is it using TDC? If so, maybe try turn it off...
🙁 Yeah. If I remember correctly the stripping routine is followed immediately by a `relax_entropy` phase. The relax stuff is all a bit of a black box to me, but...
Thanks @mjoyceGR for writing this up. @evbauer I like that idea. We could create a new `phase_relax` (which could be -1) and have that get set overriding everything else if...
Hi Sunny, My initial reaction is that what you're proposing is a clear improvement and we should do it. It's also a straightforward change, which is nice. My hesitation is...
If no one objects I'd like to go ahead and make this change... @evbauer? @orlox?
Ok, I've implemented this in the branch brunt_in_rotation. If that passes I'll merge it in.
Do we currently pass on `main` with FPE checks turned on? If so very happy to trigger a run… otherwise I'm not quite sure what I'd be looking for. -Adam...
Ok. In that case I don't think we should wait for FPE checks to pass. However in the meantime I see some failures on [testhub](https://testhub.mesastar.org/brunt_in_rotation/commits/2c01409). Looks like `1M_thermohaline` and `ppisn`....