Adam Jermyn

I like this plan. And just to clarify, during stage 2 we're moving things based on the intended time-at-which-it-is-touched (so that we can make that change later in stage 3),...

I've made a new branch (`eos_better_tests`) for this. It currently implements your suggestions on the input side. Working on the output side now.

Implemented output checks in this commit: https://testhub.mesastar.org/eos_better_tests/commits/a249bd4 These checks all throw an `ierr /= 0` and return immediately.

Here are the current output checks: ``` do k=1,num_eos_basic_results if (is_bad(res(k) .or. is_bad(d_dlnd(k)) .or. is_bad(d_dlnT(k))) then ierr = 1 return end if do l=1,species if (is_bad(d_dxa(k,l))) then ierr = 1...

Added. I'd be shocked if these checks matter for runtime. EOS calls take microseconds, these checks can't possibly add more than ~hundreds of cycles... Copying and pasting from slack, we...

@warrickball The composition being set in `set_composition` in `atm/test/test_atm_support.f90` had a substantial negative entry (of order -1d-3). This appears to be because one component was set by subtracting the sum...

Ok, great. As long as someone more informed than me has looked at it I'm happy! -Adam On Mon, Jun 28, 2021 at 3:52 PM, Warrick Ball ***@***.***> wrote: >...

I verified this on `6b537f2`: TDC causes the case to hit lots of retries and fail.

Was MLT++ about supersonic convection? I always thought it was about locally super-Eddington convection, but I could well be confused... My immediate reaction to 'MLT + supersonic' is that I...

I think the motivation is that @orlox saw strongly supersonic convection in `ccsn_IIp` when run with TDC and was concerned about that, but he'll know more than I do...