Adam Lee

Results 78 comments of Adam Lee

> @adam-code-labx Looks like there is a test failing, related to the brands column? Just running the tests on my side again and I am now getting this error Runtime:...

> BladeIconsServiceProvider Solved with `vendor/bin/monorepo-builder merge` then had to remove composer.lock then run `composer i` Also fixed the product test and added a test for the brands table.

@glennjacobs ok disappointing I have never really come across performance issues directly related to Filament Tables. Anyway this PR does not have to depend on filament. Do you want me...

> > when our new datatables PR is made. As I don't believe we'll be making a release before datatables and search is ready. > > can the Brand go...

@wychoong @alecritson Should be good to go now. Had to recreate as creating patch from various commits and trying to drop the datatables failed 😭 The tests are all passing...

> Hey @adam-code-labx > > I've pulled this down this morning and had a little look, just a couple of questions/points: > > 1. When clicking "cancel" on the create...

@alecritson @glennjacobs I will wait for the data tables and other PR's to get merged to develop then open another PR for the page refactor later. Closing this one for...

@alecritson I will also be looking to show my client a demo next week so need to add their logo to the hub. Shall I put a PR together to...

Sure there is a still a little more work on this one as currently copied over from manage features should be completed by tomorrow. Would be nice to see both...

@glennjacobs Ok this one is ready for review. I removed the manage features and created a few tests so should be good for the next beta. Unless there is anything...