Adam Lee

Results 78 comments of Adam Lee

Will check and make a few unit tests on this tonight

> I don't think it's going to work tbh, cause the `__call` method never gets fired 🤔 @alecritson you are absolutely right. Currently the trait allows you to extend any...

Well I have never been one to back down from a challenge

Solved @alecritson now overridden the instance on run time Can you test again please. I added an additional test for shouldBeSearchable seems to work my side.

I kept the other methods as swap is still useful especially if we want to pass in a specific model class. Package for instance would then override the model mapping

Strange why HasUrlsTraitTest is failing the entire test suite passes locally 🤷🏻‍♂️

Hi @alecritson did you get chance to review my changes on this one?

I will test further with the scout command meanwhile please try extending with GetCandy\Models\Product or BaseModel otherwise the eloquent trait will never be called it should be working as the...

> Considering we use Polymorphic relations which use the fully qualified name for the model, would it be better to introduce [Custom Types](https://laravel.com/docs/9.x/eloquent-relationships#custom-polymorphic-types) so we don't have to worry about...

@alecritson @glennjacobs Just pushed the ModelManifest refactor. I will recreate the tests tonight and add the additional ones to cover morphs. Note on morphs: You need to make sure to...