Adam Lee

Results 78 comments of Adam Lee

@glennjacobs @alecritson Stubbed out a few additional tests so will look to update these tomorrow night then work on the docs.

@alecritson @glennjacobs This is now ready for you guys to review. Added quite a lot of tests. The only remaining extra morph ones to write are: - can_get_media_thumbnail_morph_relation_when_using_extended_model - can_get_prices_relation_when_using_extended_model...

Great work on the filament tables integration @alecritson it is now much easier to create these page resources 😉

@alecritson Also we're not migrating existing data into the new format, meaning if someone was to upgrade and run the migrations as they are currently, they'd lose all their brands....

Instead of product relation table I have linked the counter for now to filter the products by brand.

Ok working on this now.

@alecritson I have chained this one to existing MigrationsEnded listener with some additional checks inside the new state class. Also before the removing the brand column I added an additional...

> @adam-code-labx Are you finished up for now? So I can pull this down and give it a test ? Sure I will can add some some tests later tonight.

@alecritson Personally I would prefer it grouped on the left especially with the menu grouping which I am using in my hub customisations branch. Settings I am going to be...

> > Personally I'd hold off doing a PR with filament forms. It would be quite a big undertaking and I don't think we'll be looking to add it any...