lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Component suggested refactor

Open adam-code-labx opened this issue 2 years ago • 1 comments

This is the 2nd PR (WIP) in relation to #408 This includes merges from branches (#456 #421 #461)

I don't think we need the duplication of the show edit index components. Also moved ProductType to the pages root as I believe it doesn't really suit any purpose in Products component namespace

Pages and components are now auto-loaded so I feel this is a better direction to remove those duplicate components.

Also I have introduced abstract resource classes and PageComponent. One of the reasons is to be able to define the navigations labels icon and group instead of having too hard code them. If this sounds like a good idea I will continue on this and dynamically generate the menus.

@alecritson @glennjacobs These are just suggestions at this stage and I have not had chance to create any tests around this. I have a separate branch for hub modifications on my side so I will be going in this direction for my clients project.

Look forward to hearing your feedback.

adam-code-labx avatar Aug 09 '22 12:08 adam-code-labx

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
getcandy-2-docs ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 0:53AM (UTC)

vercel[bot] avatar Aug 09 '22 12:08 vercel[bot]

@alecritson @glennjacobs I will wait for the data tables and other PR's to get merged to develop then open another PR for the page refactor later. Closing this one for now 👀

adam-code-labx avatar Aug 27 '22 11:08 adam-code-labx