Abhijit Parida

Results 9 comments of Abhijit Parida

You also need to change all the method calls. Bonus: add unit tests for the new method.

I fixed the build config issue. Update your fork accordingly. I also recommend using different branches for each pull request. See: https://guides.github.com/introduction/flow/ > Never added a unit test myself. Could...

No. Just ensure that the app builds successfully without any warnings/errors.

Sure, go ahead! But please keep the existing launcher icons as they are.

Make a separate PR.

Just one will do. Something like "Update build config for Android Studio 3.2".

You might also have to modify `.travis.yml` if you are going to change the SDK Build Tools version.